Skip to content

Latest modifications from Dev-iL (addressing #1, #6, #7) - #8

Merged
sco1 merged 17 commits into
StackOverflowMATLABchat:developfrom
Dev-iL:develop
Jan 7, 2018
Merged

sco1 merged 17 commits into
StackOverflowMATLABchat:developfrom
Dev-iL:develop

Conversation

@Dev-iL

@Dev-iL Dev-iL commented Jan 3, 2018

Copy link
Copy Markdown
Member

No description provided.

- Added the private methods `waitTillFigureLoaded` and `waitTillWebwindowLoaded`.
- Added the public method `waitForFigureReady(hUIFig)` - this blocking method returns only after determining that the UIFigure was fully loaded, or if 2*timeout was reached.
- Refactored a couple of functions (getWebWindow, getWidgetID) to make their inner workings much clearer.
- TODO: add the new public method to Readme.md.
- TODO: test on older MATLAB versions.
- Ignoring hidden figures (that don't have Controllers) when trying to convert hWebwindow -> hUIFigure.
- Corrected call to waitTillFigureLoaded.
- Improved unfinished warning message.
- widgetID is now a structure (this is more robust).
- Refactored helper styling methods - now all go through setStyle.
- Adapted TableDemo to new ID conventions.
- getWidgetInfo is possibly broken (due to the "registry.byId" call which doesn't work in the general ID_struct case). Internal documentation updated accordingly.
@Dev-iL

Dev-iL commented Jan 3, 2018

Copy link
Copy Markdown
Member Author

Looks like I forgot to update the Readme... :)

Dev-iL added 6 commits January 4, 2018 11:50
- Cleaned up getWidgetID: separated some experimental fallback functionality into getWidgetIDFromDijit.
- Made use of the WidgetID class where appropriate.
- Added a warning for unsupported UI objects.
- Removed incorrect comment.
- Added some useful debugging code at the end.
- TODO: make uniform indentation width (2 or 4).
- TODO: be consistent instead of "hWin, win, hWebwindow" etc.
- Method is now known as aboutJSLibs().
- Method now also returns the ReactJS version.
- Dojo version is now returned as a string (or on older versions, a JSON-stripped char vector).
- Added some more debugging commands for exploring React.
- Added information about new/changed methods.
- Added breaks (----) to improve readability.
- Modified some aspects of the document according to the conventions of https://github.com/DavidAnson/markdownlint/blob/v0.6.4/doc/Rules.md .
- aboutJSLibs() - Dojo version is now returned as a character array for newer MATLAB versions too.
(Reverted the implmented suggestion to remove double whitespace line endings @ Methods list)
@Dev-iL
Dev-iL requested a review from sco1 January 7, 2018 10:24
sco1
sco1 previously requested changes Jan 7, 2018

@sco1 sco1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than getWebElements needing a warning toggle, LGTM. Addresses the current issues on both of my test machines.

@sco1
sco1 dismissed their stale review January 7, 2018 17:27

Testing something

@Dev-iL

Dev-iL commented Jan 7, 2018

Copy link
Copy Markdown
Member Author

@sco1 Please merge when you're done testing (assuming there are no further comments).

@sco1
sco1 merged commit 947c54e into StackOverflowMATLABchat:develop Jan 7, 2018
@sco1

sco1 commented Jan 7, 2018

Copy link
Copy Markdown
Member

Thanks @Dev-iL, you're a magician :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants